feat(examples): Adding Tracetest Typescript Example #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanrahic
reviewed
Jan 25, 2024
| name: pokeshop | ||
|
|
||
| services: | ||
| app: |
There was a problem hiding this comment.
I'd say naming this tracetest-client makes most sense.
adnanrahic
reviewed
Jan 25, 2024
| otel-collector: | ||
| condition: service_started | ||
|
|
||
| tracetest-agent: |
There was a problem hiding this comment.
Putting this at the top with tracetest-client would make sense to keep them together for clarity.
adnanrahic
reviewed
Jan 25, 2024
| @@ -0,0 +1,66 @@ | |||
| import Tracetest from '@tracetest/core'; | |||
There was a problem hiding this comment.
I think renaming @tracetest/core to @tracetest/client will make sense in the long run. We would only call the OSS product Tracetest Core. WDYT?
|
This is awesome! Great work @xoscar 💪 I have a technical question. How does the npm client library interact with Tracetest Agent? I don't quite understand that part. |
jfermi
reviewed
Jan 26, 2024
Co-authored-by: Julianne Fermi <[email protected]>
kdhamric
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the examples folder adding the Typescript example using the new
@tracetest/clientpackage.Changes
Fixes
Checklist
Loom video